linux-kernel - Re: [PATCH 1/5] zram: remove the call to page_endio in the bio end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Mar 2023 16:16:25 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Minchan Kim <minchan@...nel.org>
Cc:     Pankaj Raghav <p.raghav@...sung.com>, martin@...ibond.com,
        axboe@...nel.dk, akpm@...ux-foundation.org, hubcap@...ibond.com,
        willy@...radead.org, viro@...iv.linux.org.uk,
        senozhatsky@...omium.org, brauner@...nel.org,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        mcgrof@...nel.org, linux-block@...r.kernel.org,
        gost.dev@...sung.com, linux-mm@...ck.org, devel@...ts.orangefs.org
Subject: Re: [PATCH 1/5] zram: remove the call to page_endio in the bio
 end_io handler

On Thu, Mar 30, 2023 at 03:51:54PM -0700, Minchan Kim wrote:
> > to remove the call to page_endio() function that unlocks or marks
> > writeback end on the page.
> > 
> > Rename the endio handler from zram_page_end_io to zram_read_end_io as
> > the call to page_endio() is removed and to associate the callback to the
> > operation it is used in.
> 
> Since zram removed the rw_page and IO comes with bio from now on,
> IIUC, we are fine since every IO will go with chained-IO. Right?

writeback_store callszram_bvec_read with a NULL bio, that is it just
fires off an async read without any synchronization.