linux-kernel - Re: [PATCH] peci: Constify struct peci_controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f86178f9c276fe2d242d7f99b31c94459d65ed1f.camel@intel.com>
Date:   Thu, 30 Mar 2023 23:39:12 +0000
From:   "Winiarska, Iwona" <iwona.winiarska@...el.com>
To:     "zev@...ilderbeest.net" <zev@...ilderbeest.net>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "andrew@...id.au" <andrew@...id.au>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "joel@....id.au" <joel@....id.au>,
        "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>
Subject: Re: [PATCH] peci: Constify struct peci_controller_ops

On Mon, 2023-03-27 at 15:43 -0700, Zev Weiss wrote:
> As with most ops structs, we never modify it at runtime, and keeping
> function pointers in read-only memory is generally a good thing
> security-wise.
> 
> Signed-off-by: Zev Weiss <zev@...ilderbeest.net>

Reviewed-by: Iwona Winiarska <iwona.winiarska@...el.com>

Thanks
-Iwona

> ---
>  drivers/peci/controller/peci-aspeed.c | 2 +-
>  drivers/peci/core.c                   | 4 ++--
>  include/linux/peci.h                  | 4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)