linux-kernel - Re: [PATCH] scsi: target: return -ENOMEM when kzalloc failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73695d8e-a779-3c9c-5a46-b5a23381dff2@nvidia.com>
Date:   Thu, 30 Mar 2023 07:59:03 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
Subject: Re: [PATCH] scsi: target: return -ENOMEM when kzalloc failed

On 3/29/23 19:38, Jiapeng Chong wrote:
> The driver is using -1 instead of the -ENOMEM defined macro to specify
> that a buffer allocation failed.
>
> drivers/target/iscsi/iscsi_target.c:691 iscsi_target_init_module() warn: returning -1 instead of -ENOMEM is sloppy.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4644
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   drivers/target/iscsi/iscsi_target.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index 834cce50f9b0..d3a40c3caaf5 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -688,7 +688,7 @@ static int __init iscsi_target_init_module(void)
>   	pr_debug("iSCSI-Target "ISCSIT_VERSION"\n");
>   	iscsit_global = kzalloc(sizeof(*iscsit_global), GFP_KERNEL);
>   	if (!iscsit_global)
> -		return -1;
> +		return -ENOMEM;
>   
>   	spin_lock_init(&iscsit_global->ts_bitmap_lock);
>   	mutex_init(&auth_id_lock);

you can also just use goto out, it has return -ENOMEM, no biggy..
Also, it will be useful to print the error message here as we
are making this change..

irrespective of that :

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck