linux-kernel - Re: [PATCH 2/5] staging: iio: resolver: ad2s1210: Add explicit include for of.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Mar 2023 09:38:20 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Rob Herring <robh@...nel.org>
CC:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Marcelo Schmitt <marcelo.schmitt1@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "Marc Zyngier" <maz@...nel.org>, <linux-iio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-staging@...ts.linux.dev>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-acpi@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/5] staging: iio: resolver: ad2s1210: Add explicit
 include for of.h

On Wed, 29 Mar 2023 16:20:43 -0500
Rob Herring <robh@...nel.org> wrote:

> With linux/acpi.h no longer implicitly including of.h, add an explicit
> include of of.h to fix the following error:
> 
> drivers/staging/iio/resolver/ad2s1210.c:706:21: error: implicit declaration of function 'of_match_ptr' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  drivers/staging/iio/resolver/ad2s1210.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index e4cf42438487..eb364639fa58 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -7,6 +7,7 @@
>  #include <linux/types.h>
>  #include <linux/mutex.h>
>  #include <linux/device.h>
> +#include <linux/of.h>
>  #include <linux/spi/spi.h>
>  #include <linux/slab.h>
>  #include <linux/sysfs.h>
>