linux-kernel - Re: [PATCH net v2 0/3] fix header length on skb merging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168016741871.21198.8299198857300036519.git-patchwork-notify@kernel.org>
Date:   Thu, 30 Mar 2023 09:10:18 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Arseniy Krasnov <AVKrasnov@...rdevices.ru>
Cc:     stefanha@...hat.com, sgarzare@...hat.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        bobby.eshleman@...edance.com, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...rdevices.ru,
        oxffffaa@...il.com, avkrasnov@...rdevices.ru
Subject: Re: [PATCH net v2 0/3] fix header length on skb merging

Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Tue, 28 Mar 2023 14:30:10 +0300 you wrote:
> Hello,
> 
> this patchset fixes appending newly arrived skbuff to the last skbuff of
> the socket's queue during rx path. Problem fires when we are trying to
> append data to skbuff which was already processed in dequeue callback
> at least once. Dequeue callback calls function 'skb_pull()' which changes
> 'skb->len'. In current implementation 'skb->len' is used to update length
> in header of last skbuff after new data was copied to it. This is bug,
> because value in header is used to calculate 'rx_bytes'/'fwd_cnt' and
> thus must be constant during skbuff lifetime. Here is example, we have
> two skbuffs: skb0 with length 10 and skb1 with length 4.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/3] virtio/vsock: fix header length on skb merging
    https://git.kernel.org/netdev/net/c/f7154d967bc4
  - [net,v2,2/3] virtio/vsock: WARN_ONCE() for invalid state of socket
    https://git.kernel.org/netdev/net/c/b8d2f61fdf2a
  - [net,v2,3/3] test/vsock: new skbuff appending test
    https://git.kernel.org/netdev/net/c/25209a3209ec

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html