linux-kernel - Re: [PATCH] net: qrtr: Do not do DEL_SERVER broadcast after DEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7da90524-37b3-0168-6326-a0a46b287736@quicinc.com>
Date:   Thu, 30 Mar 2023 15:28:07 +0530
From:   Sricharan Ramabadhran <quic_srichara@...cinc.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <mani@...nel.org>, <manivannan.sadhasivam@...aro.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <linux-arm-msm@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: qrtr: Do not do DEL_SERVER broadcast after
 DEL_CLIENT



On 3/30/2023 10:02 AM, Jakub Kicinski wrote:
> On Wed, 29 Mar 2023 18:37:30 +0530 Sricharan R wrote:
>> When the qrtr socket is released, qrtr_port_remove gets called, which
>> broadcasts a DEL_CLIENT. After this DEL_SERVER is also additionally
>> broadcasted, which becomes NOP, but triggers the below error msg.
>>
>> "failed while handling packet from 2:-2", since remote node already
>> acted upon on receiving the DEL_CLIENT, once again when it receives
>> the DEL_SERVER, it returns -ENOENT.
>>
>> Fixing it by not sending a 'DEL_SERVER' to remote when a 'DEL_CLIENT'
>> was sent for that port.
> 
> You use the word "fix" so please add a Fixes tag.
> 

  ok

>> Signed-off-by: Ram Kumar D <quic_ramd@...cinc.com>
>> Signed-off-by: Sricharan R <quic_srichara@...cinc.com>
> 
> Spell out full names, please.

  ok

Regards,
  Sricharan