linux-kernel - Re: [PATCH RESEND 1/6] dt-bindings: memory-controllers: mediatek,smi-common: add mt8365

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Mar 2023 01:53:57 +0000
From:   Yong Wu (吴勇) <Yong.Wu@...iatek.com>
To:     "amergnat@...libre.com" <amergnat@...libre.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH RESEND 1/6] dt-bindings: memory-controllers:
 mediatek,smi-common: add mt8365

On Wed, 2023-03-29 at 11:52 +0200, Alexandre Mergnat wrote:
> 
> Add binding description for mediatek,mt8365-smi-common
> 
> Signed-off-by: Alexandre Mergnat <amergnat@...libre.com>
> ---
>  .../devicetree/bindings/memory-controllers/mediatek,smi-
> common.yaml   | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/memory-
> controllers/mediatek,smi-common.yaml
> b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-
> common.yaml
> index a8fda30cccbb..d599a190952f 100644
> --- a/Documentation/devicetree/bindings/memory-
> controllers/mediatek,smi-common.yaml
> +++ b/Documentation/devicetree/bindings/memory-
> controllers/mediatek,smi-common.yaml
> @@ -49,6 +49,10 @@ properties:
>            - const: mediatek,mt7623-smi-common
>            - const: mediatek,mt2701-smi-common
> 
> +      - items:
> +          - const: mediatek,mt8365-smi-common
> +          - const: mediatek,mt8186-smi-common
> +

mt8365 is not same with mt8186.

From the code, the bus_sel for mt8186 is:
.bus_sel  = F_MMU1_LARB(1) | F_MMU1_LARB(4) | F_MMU1_LARB(7),

the bus_sel for mt8365 is:
.bus_sel  = F_MMU1_LARB(2) | F_MMU1_LARB(4),

I guess we should add a independent "mediatek,mt8365-smi-common".

>    reg:
>      maxItems: 1
> 
> 
> --
> 2.25.1
>