linux-kernel - Re: [PATCH] fs: consolidate duplicate dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31bd4a176344cd0746f1ec519eb8caca2ef2ba68.camel@kernel.org>
Date:   Thu, 30 Mar 2023 07:15:36 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Eric Van Hensbergen <ericvh@...il.com>,
        Latchesar Ionkov <lucho@...kov.net>,
        Dominique Martinet <asmadeus@...ewreck.org>,
        Joel Becker <jlbec@...lplan.org>,
        Christoph Hellwig <hch@....de>, Tejun Heo <tj@...nel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>,
        v9fs-developer@...ts.sourceforge.net,
        Chuck Lever <chuck.lever@...cle.com>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fs: consolidate duplicate dt_type helpers

On Thu, 2023-03-30 at 12:48 +0200, Greg Kroah-Hartman wrote:
> On Thu, Mar 30, 2023 at 06:41:43AM -0400, Jeff Layton wrote:
> > There are three copies of the same dt_type helper sprinkled around the
> > tree. Convert them to use the common fs_umode_to_dtype function instead,
> > which has the added advantage of properly returning DT_UNKNOWN when
> > given a mode that contains an unrecognized type.
> > 
> > Cc: Chuck Lever <chuck.lever@...cle.com>
> > Cc: Phillip Potter <phil@...lpotter.co.uk>
> > Suggested-by: Christian Brauner <brauner@...nel.org>
> > Signed-off-by: Jeff Layton <jlayton@...nel.org>
> > ---
> >  fs/configfs/dir.c | 9 ++-------
> >  fs/kernfs/dir.c   | 8 +-------
> >  fs/libfs.c        | 9 ++-------
> >  3 files changed, 5 insertions(+), 21 deletions(-)
> > 
> > v2: consolidate S_DT helper as well
> > v3: switch existing dt_type helpers to use fs_umode_to_dtype
> >     drop v9fs hunks since they're no longer needed
> 
> You forgot the "v3" in the subject line :(
> 

Yeah, I noticed, sorry. It's the attention to detail that makes me such
a successful kernel developer! ;)
-- 
Jeff Layton <jlayton@...nel.org>