linux-kernel - Re: [PATCH v6 07/12] dt-bindings: serial: Document ma35d1 uart controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230330131219.GA1849090-robh@kernel.org>
Date:   Thu, 30 Mar 2023 08:12:19 -0500
From:   Rob Herring <robh@...nel.org>
To:     Jacky Huang <ychuang570808@...il.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        krzysztof.kozlowski+dt@...aro.org, lee@...nel.org,
        mturquette@...libre.com, sboyd@...nel.org, p.zabel@...gutronix.de,
        gregkh@...uxfoundation.org, jirislaby@...nel.org,
        devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        arnd@...db.de, schung@...oton.com, mjchen@...oton.com,
        Jacky Huang <ychuang3@...oton.com>
Subject: Re: [PATCH v6 07/12] dt-bindings: serial: Document ma35d1 uart
 controller

On Thu, Mar 30, 2023 at 06:52:11PM +0800, Jacky Huang wrote:
> 
> 
> On 2023/3/30 下午 03:33, Krzysztof Kozlowski wrote:
> > On 29/03/2023 10:44, Jacky Huang wrote:
> > > Dear Krzysztof,
> > > 
> > > 
> > > Thanks for your review.
> > > 
> > > 
> > > On 2023/3/29 下午 04:20, Krzysztof Kozlowski wrote:
> > > > On 28/03/2023 04:19, Jacky Huang wrote:
> > > > > From: Jacky Huang <ychuang3@...oton.com>
> > > > > 
> > > > > Add documentation to describe nuvoton ma35d1 uart driver bindings.
> > > > > 
> > > > This depends on clock patches, so it must be taken together.
> > > > 
> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > > > 
> > > > Best regards,
> > > > Krzysztof
> > > > 
> > > OK, I will combine this patch with the clock patch.
> > I don't know what you mean by "combine", but I don't think this is what
> > we want. You must clearly state all dependencies and patch merging
> > strategy/way.
> > 
> > Best regards,
> > Krzysztof
> > 
> 
> Dear Krzysztof,
> 
> 
> I may be misunderstanding your request.
> I thought it was moving the "nuvoton,ma35d1-serial.yaml" to the patch of
> nuvoton,ma35d1-clk.h.
> Would you please provide guidance what should I do next on this [PATCH v6
> 07/12]. Thank you.

The only combining you should do is putting the 2 patches in the same 
series. Combining to 1 patch would be wrong.

Your other option is just drop the header in the example and use the 
raw numbers. Then there is no dependency to manage and each subsystem 
maintainer can take the relevant patches.

Rob