linux-kernel - Re: [PATCH v2] Documentation: Add document for false sharing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCWXET8MPoyUc/Md@debian.me>
Date:   Thu, 30 Mar 2023 21:05:05 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Shakeel Butt <shakeelb@...gle.com>
Cc:     Feng Tang <feng.tang@...el.com>, Jonathan Corbet <corbet@....net>,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Randy Dunlap <rdunlap@...radead.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Joe Mario <jmario@...hat.com>, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Eric Dumazet <edumazet@...gle.com>, dave.hansen@...el.com,
        ying.huang@...el.com, tim.c.chen@...el.com, andi.kleen@...el.com
Subject: Re: [PATCH v2] Documentation: Add document for false sharing

On Wed, Mar 29, 2023 at 09:51:56PM -0700, Shakeel Butt wrote:
> > > +* Turn hot global data to 'per-cpu data + global data' when possible,
> > > +  or reasonably increase the threshold for syncing per-cpu data to
> > > +  global data, to reduce or postpone the 'write' to that global data.
> > > +
> > > +  - Commit 520f897a3554 ("ext4: use percpu_counters for extent_status cache hits/misses")
> > > +  - Commit 56f3547bfa4d ("mm: adjust vm_committed_as_batch according to vm overcommit policy")
> > > +
> >
> > Here's what I mean by bridging conjunctions to example commits as I reviewed
> > in v1 [1]:
> >
> 
> This is too much and unneeded nitpicking. The patch looks good as is.

As ESL people, I feel there is a gap when a description paragraph is
followed immediately by some sort of lists without bridging (conjunction
between them). I expect a smooth transition in this case. Even though
before the list it is written "(with examples)", I think the conjunction
is needed anyway.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)