linux-kernel - Re: [RFC PATCH 1/2] gpio: davinci: Do not clear the bank intr enable bit in save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48d7ba60-aa7b-8d93-fcf0-c7e64908e9f5@ti.com>
Date:   Thu, 30 Mar 2023 08:34:19 +0530
From:   "J, KEERTHY" <j-keerthy@...com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Dhruva Gole <d-gole@...com>
CC:     Vibhore Vardhan <vibhore@...com>, Tony Lindgren <tony@...mide.com>,
        Vignesh <vigneshr@...com>, Bartosz Golaszewski <brgl@...ev.pl>,
        <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Devarsh Thakkar <devarsht@...com>
Subject: Re: [RFC PATCH 1/2] gpio: davinci: Do not clear the bank intr enable
 bit in save_context



On 3/28/2023 6:59 PM, Linus Walleij wrote:
> On Thu, Mar 23, 2023 at 1:29 PM Dhruva Gole <d-gole@...com> wrote:
> 
>> The interrupt enable bits might be set if we want to use the GPIO as
>> wakeup source. Clearing this will mean disabling of interrupts in the GPIO
>> banks that we may want to wakeup from.
>> Thus remove the line that was clearing this bit from the driver's save
>> context function.
>>
>> Fixes: 0651a730924b ("gpio: davinci: Add support for system suspend/resume PM")
>> Cc: Devarsh Thakkar <devarsht@...com>
>> Signed-off-by: Dhruva Gole <d-gole@...com>
> 
> Looks like the right solution to me.
> I'm a bit surprised given how long we have had this driver.
> I suppose people have used out-of-tree patches for suspend/resume. :(
> 
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Acked-by: Keerthy <j-keerthy@...com>

> 
> Yours,
> Linus Walleij