linux-kernel - Re: [PATCH] Add "X570S AORUS ELITE" to known working boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a89c1f4-f876-3a5d-465c-6d374890b6e3@redhat.com>
Date:   Fri, 31 Mar 2023 19:34:26 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     linux@...ssschuh.net, Brandon Nielsen <nielsenb@...fuse.net>
Cc:     Mark Gross <markgross@...nel.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add "X570S AORUS ELITE" to known working boards

Hi,

On 3/31/23 11:44, linux@...ssschuh.net wrote:
> Hi,
> 
> thanks for the patch!
> 
> 
> Mar 31, 2023 04:01:37 Brandon Nielsen <nielsenb@...fuse.net>:
> 
>> ---
>> drivers/platform/x86/gigabyte-wmi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
>> index 4dd39ab6ecfa..ca5124e31d2c 100644
>> --- a/drivers/platform/x86/gigabyte-wmi.c
>> +++ b/drivers/platform/x86/gigabyte-wmi.c
>> @@ -160,6 +160,7 @@ static const struct dmi_system_id gigabyte_wmi_known_working_platforms[] = {
>>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 GAMING X"),
>>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 I AORUS PRO WIFI"),
>>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 UD"),
>> +   DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570S AORUS ELITE"),
>>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("Z690M AORUS ELITE AX DDR4"),
>>     { }
>> };
>> -- > 2.39.2
> 
> 
> This patch is missing a proper subject line, a commit message and Signed-off-by.
> Please send a v2 and take a look how similar patches are structured.
> 
> https://lore.kernel.org/lkml/20220705184407.14181-1-parherman@gmail.com/

Since I'm preparing a fixes pull-req to send to Linus today
and since this is just a simple hw-id addition I have merged this now,
so that it can be included in the fixes pull-req.

I have fixed the subject and solved the missing Signed-off-by problem
by setting myself as author and crediting Brandon with a:

Reported-by: Brandon Nielsen <nielsenb@...fuse.net>

Regards,

Hans