linux-kernel - Re: [PATCH v4 01/15] rust: enable the `pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCddVfb9vUw8j7u/@boqun-archlinux>
Date:   Fri, 31 Mar 2023 15:23:17 -0700
From:   Boqun Feng <boqun.feng@...il.com>
To:     y86-dev@...tonmail.com
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Alice Ryhl <alice@...l.io>, rust-for-linux@...r.kernel.org,
        linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
        Andreas Hindborg <a.hindborg@...sung.com>,
        Alice Ryhl <aliceryhl@...gle.com>
Subject: Re: [PATCH v4 01/15] rust: enable the `pin_macro` feature

On Fri, Mar 31, 2023 at 02:52:18PM -0700, Boqun Feng wrote:
> On Fri, Mar 31, 2023 at 09:51:35PM +0000, y86-dev@...tonmail.com wrote:
> > From: Benno Lossin <y86-dev@...tonmail.com>
> > 
> > This feature enables the use of the `pin!` macro for the `stack_pin_init!`
> > macro. This feature is already stabilized in Rust version 1.68.
> > 
> > Signed-off-by: Benno Lossin <y86-dev@...tonmail.com>
> > Cc: Gary Guo <gary@...yguo.net>
> > Cc: Andreas Hindborg <a.hindborg@...sung.com>
> > Cc: Alice Ryhl <aliceryhl@...gle.com>
> 
> Acked-by: Boqun Feng <boqun.feng@...il.com>
> 

Hmm.. actually I think you will need to add this in the
scripts/Makefile.build, because the user (stack_pin_init!()) is a macro,
feel free to add my acked-by after that.

Regards,
Boqun

> Regards,
> Boqun
> 
> > ---
> >  rust/kernel/lib.rs | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
> > index 223564f9f0cc..4317b6d5f50b 100644
> > --- a/rust/kernel/lib.rs
> > +++ b/rust/kernel/lib.rs
> > @@ -17,6 +17,7 @@
> >  #![feature(core_ffi_c)]
> >  #![feature(dispatch_from_dyn)]
> >  #![feature(generic_associated_types)]
> > +#![feature(pin_macro)]
> >  #![feature(receiver_trait)]
> >  #![feature(unsize)]
> > 
> > --
> > 2.39.2
> > 
> >