linux-kernel - Re: power_supply_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230331235409.tub5oxes4cse7wne@mercury.elektranox.org>
Date:   Sat, 1 Apr 2023 01:54:09 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Alistair <alistair@...stair23.me>
Cc:     Linus Walleij <linus.walleij@...aro.org>, ye.xingchen@....com.cn,
        pali@...nel.org, sravanhome@...il.com, linux-pm@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: power_supply_show_property Kernel Oops

Hi,

On Thu, Mar 30, 2023 at 06:00:41PM +1000, Alistair wrote:
> > I did not look deeply, but it's at least missing an update to
> > power_supply_attrs. I guess you were 'lucky' that it did not crash
> > with v6.2.
> 
> Do you mind pointing to an example that does this correctly? I don't see
> anything obviously wrong compared to the in-tree max* drivers.
> 
> Anything to help point me in the right direction would be greatly
> appreciated :)

I am talking about the extra additions to the core, that have been
done incorrectly. You cannot see that in other max* drivers. The
additions to the core basically break the core and thus the drivers
are broken.

> > None of the extra properties are acceptable upstream btw.:
> > 
> > POWER_SUPPLY_PROP_CURRENT_MAX2:
> >     The driver seems to use CURRENT_MAX2 for input current;
> >     POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT should be used for that
> > 
> > POWER_SUPPLY_PROP_CHARGER_MODE:
> >     OTG should be handled via a regulator
> > 
> > POWER_SUPPLY_PROP_STATUS_EX:
> >     Use extcon for connectors
> 
> Thanks! I figured as much. These are just taken from the vendor
> tree, I need to clean everything up for upstreaming. I just wanted
> to have a working base point to start.

That did not turn out that well so far... :)

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)