linux-kernel - Re: [PATCH] iio: adc: ad7192: Change "shorted" channels to differential

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf20f272465717da960ae3a3c04eb6c1ebfaf3d3.camel@gmail.com>
Date:   Fri, 31 Mar 2023 08:26:12 +0200
From:   Nuno Sá <noname.nuno@...il.com>
To:     Paul Cercueil <paul@...pouillou.net>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alisa Roman <alisa.roman@...log.com>
Subject: Re: [PATCH] iio: adc: ad7192: Change "shorted" channels to
 differential

On Thu, 2023-03-30 at 12:21 +0200, Paul Cercueil wrote:
> The AD7192 provides a specific channel configuration where both
> negative
> and positive inputs are connected to AIN2. This was represented in
> the
> ad7192 driver as a IIO channel with .channel = 2 and .extended_name
> set
> to "shorted".
> 
> The problem with this approach, is that the driver provided two IIO
> channels with the identifier .channel = 2; one "shorted" and the
> other
> not. This goes against the IIO ABI, as a channel identifier should be
> unique.
> 
> Address this issue by changing "shorted" channels to being
> differential
> instead, with channel 2 vs. itself, as we're actually measuring AIN2
> vs.
> itself.
> 
> Note that the fix tag is for the commit that moved the driver out of
> staging. The bug existed before that, but backporting would become
> very
> complex further down and unlikely to happen.
> 
> Fixes: b581f748cce0 ("staging: iio: adc: ad7192: move out of
> staging")
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> Co-developed-by: Alisa Roman <alisa.roman@...log.com>
> Signed-off-by: Alisa Roman <alisa.roman@...log.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@...log.com>