linux-kernel - Re: [PATCH SPI for-next] spi: microchip: pci1xxxx: Fix minor bugs in spi-pci1xxxx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <754b57849925e48401e6ebb3d206c966a8a08800.camel@microchip.com>
Date:   Fri, 31 Mar 2023 08:59:15 +0000
From:   <Tharunkumar.Pasumarthi@...rochip.com>
To:     <broonie@...nel.org>
CC:     <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH SPI for-next] spi: microchip: pci1xxxx: Fix minor bugs in
 spi-pci1xxxx driver

Hi Mark,

Thanks for the comments. Please find my inline replies below:

> As covered in submitting-patches.rst you should send one patch per
> change, this makes things much easier to review.

Okay. I will submit these fixes as a new patchset.

> I am unclear how chip select will ever be asserted with this change?
> Now the value is only written if we are disabling.

In PCI1xxxx, there is a common bit in hardware to enable / disable chip
select lines. I will use this bit in pci1xxxx_spi_set_cs API in 
the upcoming version of patch. Currently, this bit is used within 
pci1xxxx_spi_transfer_one API.

Thanks,
Tharun Kumar P

Content of type "message/rfc822" skipped