linux-kernel - Re: [PATCH] media: pvrusb2: clean up unneeded complexity in pvrusb2 class logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZCaiJzLYYRt7KrPp@kroah.com>
Date:   Fri, 31 Mar 2023 11:04:39 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Hans Verkuil <hverkuil@...all.nl>
Cc:     linux-kernel@...r.kernel.org, Mike Isely <isely@...ox.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] media: pvrusb2: clean up unneeded complexity in pvrusb2
 class logic

On Fri, Mar 31, 2023 at 10:08:43AM +0200, Hans Verkuil wrote:
> On 29/03/2023 08:01, Greg Kroah-Hartman wrote:
> > The pvrusb2 driver struct class logic was dynamically creating a class
> > that should have just been static as it did not do anything special and
> > was only a wrapper around a stock "struct class" implementation.  Clean
> > this all up by making a static struct class and modifying the code to
> > correctly reference it.
> > 
> > By doing so, lots of unneeded lines of code were removed, and #ifdef
> > logic was cleaned up so that the .c files are not cluttered up with
> > extra complexity following the proper kernel coding style.
> > 
> > Cc: Mike Isely <isely@...ox.com>
> > Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> > Cc: linux-media@...r.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Reviewed-by: Hans Verkuil <hverkuil-cisco@...all.nl>a

Great, thanks for the quick review.

greg k-h