linux-kernel - Re: [PATCH v2] crypto: hisilicon/trng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZCaifxC1HNlEJDf4@gondor.apana.org.au>
Date:   Fri, 31 Mar 2023 17:06:07 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     David Yang <mmyangfl@...il.com>
Cc:     Weili Qian <qianweili@...wei.com>,
        Zhou Wang <wangzhou1@...ilicon.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v2] crypto: hisilicon/trng - add support for HiSTB TRNG

On Wed, Mar 22, 2023 at 06:33:26AM +0800, David Yang wrote:
>
> +static int histb_trng_wait(struct hwrng *rng)
> +{
> +	void __iomem *base = (void __iomem *) rng->priv;

You should never need to cast something to __iomem.

Please copy what the meson driver does, that is the right way.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt