[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkda5G5b+At5s1WFudpQBQ6LDQxhE3fZj7eBhkZ=thvnQhg@mail.gmail.com>
Date: Fri, 31 Mar 2023 11:41:36 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Okan Sahin <okan.sahin@...log.com>
Cc: Bartosz Golaszewski <brgl@...ev.pl>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] gpio: ds4520: Add ADI DS4520 Regulator Support
Hi Okan,
thanks for your patch!
First: why is the word "Regulator" in the subject? I don't quite get it.
On Mon, Mar 27, 2023 at 3:01 PM Okan Sahin <okan.sahin@...log.com> wrote:
>
> Gpio I/O expander.
>
> Signed-off-by: Okan Sahin <okan.sahin@...log.com>
This commit log is too terse. Write a bit about what this hardware is.
> +config GPIO_DS4520
> + tristate "DS4520 I2C GPIO expander"
> + select REGMAP_I2C
> + help
> + GPIO driver for Maxim MAX7300 I2C-based GPIO expander.
Is it MAX7300, I don't get this, it seems super-confused.
> + Say yes here to enable the GPIO driver for the ADI DS4520 chip.
> +
> + To compile this driver as a module, choose M here: the module will
> + be called gpio-ds4520.
(...)
The driver is pretty straight-forward, but I think this can use the
generic GPIO_REGMAP helpers in
drivers/gpio/gpio-regmap.c
check other drivers selecting this helper library for inspiration.
Yours,
Linus Walleij
Powered by blists - more mailing lists