linux-kernel - Re: [PATCH v9 0/3] perf: cs-etm: Update perf to handle new Coresight Trace ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 31 Mar 2023 08:51:45 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Mike Leach <mike.leach@...aro.org>
Cc:     linux-perf-users@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org,
        linux-kernel@...r.kernel.org, suzuki.poulose@....com,
        leo.yan@...aro.org, peterz@...radead.org, mingo@...hat.com,
        will@...nel.org, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, gankulkarni@...amperecomputing.com,
        darren@...amperecomputing.com
Subject: Re: [PATCH v9 0/3] perf: cs-etm: Update perf to handle new Coresight
 Trace ID

Em Fri, Mar 31, 2023 at 06:56:42AM +0100, Mike Leach escreveu:
> The original method for allocating trace source ID values to sources was
> to use a fixed algorithm for CPU based sources of (cpu_num * 2 + 0x10).
> The STM was allocated ID 0x1.
> 
> This mechanism is broken for systems with more than 47 cores.
> 
> The kernel related patches the provide a fixed Trace ID allocation mechanism
> are now upstreamed.
> 
> This patchset updates the perf code to handle the changes to the trace ID
> notification mechanism that now uses the PERF_RECORD_AUX_OUTPUT_HW_ID
> packet to set Trace ID in the perf ETM decoders.
> 
> Applies and test oo perf/core

I'm keeping perf/core with the same contents as perf-tools-next, please
use perf-tools-next as in the future I'll stop using the old perf/core
name.

Applied, testing.

- Arnaldo
 
> Changes since v8:
> 1. Fix build issues
> 2. Fix implicit function problem
> 
> Changes since v7:
> Split from original patchset [1] to be sent separately as kernel related
> patches are now upstream.
> 
> [1] https://lore.kernel.org/linux-arm-kernel/20230116124928.5440-1-mike.leach@linaro.org/
> 
> Mike Leach (3):
>   perf: cs-etm: Move mapping of Trace ID and cpu into helper function
>   perf: cs-etm: Update record event to use new Trace ID protocol
>   perf: cs-etm: Handle PERF_RECORD_AUX_OUTPUT_HW_ID packet
> 
>  tools/include/linux/coresight-pmu.h           |  47 ++-
>  tools/perf/arch/arm/util/cs-etm.c             |  27 +-
>  tools/perf/util/cs-etm-base.c                 |   3 +-
>  .../perf/util/cs-etm-decoder/cs-etm-decoder.c |   7 +
>  tools/perf/util/cs-etm.c                      | 326 +++++++++++++++---
>  tools/perf/util/cs-etm.h                      |  14 +-
>  6 files changed, 356 insertions(+), 68 deletions(-)
> 
> -- 
> 2.17.1
> 

-- 

- Arnaldo