linux-kernel - Re: [PATCH] reiserfs: remove unused iter variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230331122146.3rmw3dqv6y573pg2@quack3>
Date:   Fri, 31 Mar 2023 14:21:46 +0200
From:   Jan Kara <jack@...e.cz>
To:     Tom Rix <trix@...hat.com>
Cc:     nathan@...nel.org, ndesaulniers@...gle.com, axboe@...nel.dk,
        akpm@...ux-foundation.org, bvanassche@....org, jack@...e.cz,
        yi.zhang@...wei.com, reiserfs-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] reiserfs: remove unused iter variable

On Fri 31-03-23 08:03:25, Tom Rix wrote:
> clang with W=1 reports
> fs/reiserfs/stree.c:1265:6: error: variable
>   'iter' set but not used [-Werror,-Wunused-but-set-variable]
>         int iter = 0;
>             ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Thanks. I've merged the patch to my tree.

								Honza

> ---
>  fs/reiserfs/stree.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c
> index 84c12a1947b2..ce5003986789 100644
> --- a/fs/reiserfs/stree.c
> +++ b/fs/reiserfs/stree.c
> @@ -1262,7 +1262,6 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th,
>  
>  #ifdef CONFIG_REISERFS_CHECK
>  	char mode;
> -	int iter = 0;
>  #endif
>  
>  	BUG_ON(!th->t_trans_id);
> @@ -1274,7 +1273,6 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th,
>  		removed = 0;
>  
>  #ifdef CONFIG_REISERFS_CHECK
> -		iter++;
>  		mode =
>  #endif
>  		    prepare_for_delete_or_cut(th, inode, path,
> -- 
> 2.27.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR