linux-kernel - RE: [EXTERNAL] Re: [PATCH v10] ASoC: tas2781: Add tas2781 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a0cfa60e2a244168edd49c3d2f6a2bd@ti.com>
Date:   Fri, 31 Mar 2023 02:19:42 +0000
From:   "Ding, Shenghao" <shenghao-ding@...com>
To:     Amadeusz Slawinski <amadeuszx.slawinski@...ux.intel.com>,
        Shenghao Ding <13916275206@....com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>
CC:     "Lu, Kevin" <kevin-lu@...com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Xu, Baojun" <x1077012@...com>, "Gupta, Peeyush" <peeyush@...com>,
        "Navada Kanyana, Mukund" <navada@...com>
Subject: RE: [EXTERNAL] Re: [PATCH v10] ASoC: tas2781: Add tas2781 driver

Hi Amadeusz Sławiński
Thanks for your comment.
Answer inline.

-----Original Message-----
From: Amadeusz Sławiński <amadeuszx.slawinski@...ux.intel.com> 
Sent: Thursday, March 30, 2023 7:54 PM
To: Shenghao Ding <13916275206@....com>; broonie@...nel.org; lgirdwood@...il.com; perex@...ex.cz; pierre-louis.bossart@...ux.intel.com
Cc: Lu, Kevin <kevin-lu@...com>; Ding, Shenghao <shenghao-ding@...com>; alsa-devel@...a-project.org; linux-kernel@...r.kernel.org; Xu, Baojun <x1077012@...com>; Gupta, Peeyush <peeyush@...com>; Navada Kanyana, Mukund <navada@...com>
Subject: [EXTERNAL] Re: [PATCH v10] ASoC: tas2781: Add tas2781 driver

On 3/29/2023 12:01 PM, Shenghao Ding wrote:
> Create tas2781 driver.
> 
> Signed-off-by: Shenghao Ding <13916275206@....com>
> 
> ---
> Changes in v10:
>   - using be16_to_cpu and be32_to_cpu instead of SMS_HTONS and SMS_HTONL
>   - optimize and reduce the boundary checks
>   - Add comments on some kmemdup instead of kzalloc+memcpy
>   Changes to be committed:
> 	modified:   sound/soc/codecs/Kconfig
> 	modified:   sound/soc/codecs/Makefile
> 	new file:   sound/soc/codecs/tas2781-dsp.c
> 	new file:   sound/soc/codecs/tas2781-dsp.h
> 	new file:   sound/soc/codecs/tas2781-i2c.c
> 	new file:   sound/soc/codecs/tas2781.h
> ---

...

> +
> +static int fw_parse_block_data_kernel(struct tasdevice_fw *tas_fmw,
> +	struct tasdev_blk *block, const struct firmware *fmw, int offset) {
> +	const unsigned char *data = fmw->data;
> +
> +	if (offset + 16 > fmw->size) {
> +		dev_err(tas_fmw->dev, "%s: File Size error\n", __func__);
> +		offset = -EINVAL;
> +		goto out;
> +	}
> +	block->type = be32_to_cpup((__be32 *)&data[offset]);

Wouldn't just be32_to_cpu(data[offset]) work instead of be32_to_cpup? 
Same in other cases.
[DING] data[] is a char array, the code will convert data[offset], data[offset + 1], 
data[offset + 2] and data[offset + 3] into host instead of data[offset] only.