linux-kernel - Re: [PATCH v3 9/9] media: starfive: Add Starfive Camera Subsystem driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202303312218.LXqt9wcT-lkp@intel.com>
Date:   Fri, 31 Mar 2023 22:38:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jack Zhu <jack.zhu@...rfivetech.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Robert Foss <rfoss@...nel.org>,
        Todor Tomov <todor.too@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
        Hans Verkuil <hverkuil@...all.nl>,
        Eugen Hristev <eugen.hristev@...labora.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        jack.zhu@...rfivetech.com, changhuang.liang@...rfivetech.com
Subject: Re: [PATCH v3 9/9] media: starfive: Add Starfive Camera Subsystem
 driver

Hi Jack,

I love your patch! Perhaps something to improve:

[auto build test WARNING on media-tree/master]
[also build test WARNING on robh/for-next linus/master v6.3-rc4 next-20230331]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jack-Zhu/media-dt-bindings-Add-bindings-for-JH7110-Camera-Subsystem/20230331-202001
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20230331121826.96973-10-jack.zhu%40starfivetech.com
patch subject: [PATCH v3 9/9] media: starfive: Add Starfive Camera Subsystem driver
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230331/202303312218.LXqt9wcT-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/421adbf9815b633e8bac5da7146c33aac01e283c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jack-Zhu/media-dt-bindings-Add-bindings-for-JH7110-Camera-Subsystem/20230331-202001
        git checkout 421adbf9815b633e8bac5da7146c33aac01e283c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/media/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303312218.LXqt9wcT-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/media/platform/starfive/stf_camss.c:41:5: warning: no previous prototype for 'stfcamss_get_mem_res' [-Wmissing-prototypes]
      41 | int stfcamss_get_mem_res(struct platform_device *pdev,
         |     ^~~~~~~~~~~~~~~~~~~~
--
>> drivers/media/platform/starfive/stf_isp.c:627:5: warning: no previous prototype for 'isp_close' [-Wmissing-prototypes]
     627 | int isp_close(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
         |     ^~~~~~~~~
--
   drivers/media/platform/starfive/stf_vin.c: In function 'stf_vin_map_isp_pad':
>> drivers/media/platform/starfive/stf_vin.c:99:24: warning: implicit conversion from 'enum isp_line_id' to 'enum isp_pad_id' [-Wenum-conversion]
      99 |                 pad_id = vin_map_isp_line(line);
         |                        ^
   drivers/media/platform/starfive/stf_vin.c: In function 'vin_output_init_addrs':
>> drivers/media/platform/starfive/stf_vin.c:683:20: warning: variable 'pong_addr' set but not used [-Wunused-but-set-variable]
     683 |         dma_addr_t pong_addr;
         |                    ^~~~~~~~~
   drivers/media/platform/starfive/stf_vin.c: At top level:
   drivers/media/platform/starfive/stf_vin.c:33:32: warning: 'vin_formats_raw' defined but not used [-Wunused-const-variable=]
      33 | static const struct vin_format vin_formats_raw[] = {
         |                                ^~~~~~~~~~~~~~~


vim +/stfcamss_get_mem_res +41 drivers/media/platform/starfive/stf_camss.c

    40	
  > 41	int stfcamss_get_mem_res(struct platform_device *pdev,
    42				 struct stfcamss *stfcamss)
    43	{
    44		stfcamss->syscon_base =
    45			devm_platform_ioremap_resource_byname(pdev, "syscon");
    46		if (IS_ERR(stfcamss->syscon_base))
    47			return PTR_ERR(stfcamss->syscon_base);
    48	
    49		stfcamss->isp_base =
    50			devm_platform_ioremap_resource_byname(pdev, "isp");
    51		if (IS_ERR(stfcamss->isp_base))
    52			return PTR_ERR(stfcamss->isp_base);
    53	
    54		return 0;
    55	}
    56	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests