[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <10420fbe-a0f2-fd3f-8c04-068c7ce9faab@linux.alibaba.com>
Date: Fri, 31 Mar 2023 10:43:42 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Jingbo Xu <jefflexu@...ux.alibaba.com>, xiang@...nel.org,
chao@...nel.org, huyue2@...lpad.com, linux-erofs@...ts.ozlabs.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/8] erofs: simplify erofs_xattr_generic_get()
On 2023/3/30 16:29, Jingbo Xu wrote:
> erofs_xattr_generic_get() won't be called from xattr handlers other than
> user/trusted/security xattr handler, and thus there's no need of extra
> checking.
>
> Signed-off-by: Jingbo Xu <jefflexu@...ux.alibaba.com>
> Reviewed-by: Gao Xiang <hsiangkao@...ux.alibaba.com>
I plan to apply these three patches to -next first, and then look into
the rests.
Thanks,
Gao Xiang
> ---
> fs/erofs/xattr.c | 17 +++--------------
> 1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/fs/erofs/xattr.c b/fs/erofs/xattr.c
> index dc36a0c0919c..d76b74ece2e5 100644
> --- a/fs/erofs/xattr.c
> +++ b/fs/erofs/xattr.c
> @@ -432,20 +432,9 @@ static int erofs_xattr_generic_get(const struct xattr_handler *handler,
> struct dentry *unused, struct inode *inode,
> const char *name, void *buffer, size_t size)
> {
> - struct erofs_sb_info *const sbi = EROFS_I_SB(inode);
> -
> - switch (handler->flags) {
> - case EROFS_XATTR_INDEX_USER:
> - if (!test_opt(&sbi->opt, XATTR_USER))
> - return -EOPNOTSUPP;
> - break;
> - case EROFS_XATTR_INDEX_TRUSTED:
> - break;
> - case EROFS_XATTR_INDEX_SECURITY:
> - break;
> - default:
> - return -EINVAL;
> - }
> + if (handler->flags == EROFS_XATTR_INDEX_USER &&
> + !test_opt(&EROFS_I_SB(inode)->opt, XATTR_USER))
> + return -EOPNOTSUPP;
>
> return erofs_getxattr(inode, handler->flags, name, buffer, size);
> }
Powered by blists - more mailing lists