linux-kernel - Re: [PATCH] drm/amd/display: remove unused average_render_time_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fbf84e6b-438c-0486-1ee3-7bb1171b2c0a@amd.com>
Date:   Fri, 31 Mar 2023 11:01:23 -0400
From:   Hamza Mahfooz <hamza.mahfooz@....com>
To:     Tom Rix <trix@...hat.com>, harry.wentland@....com,
        sunpeng.li@....com, Rodrigo.Siqueira@....com,
        alexander.deucher@....com, christian.koenig@....com,
        Xinhui.Pan@....com, airlied@...il.com, daniel@...ll.ch,
        nathan@...nel.org, ndesaulniers@...gle.com, aric.cyr@....com,
        HaoPing.Liu@....com, Anthony.Koo@....com, hanghong.ma@....com,
        Angus.Wang@....com, Dillon.Varone@....com
Cc:     llvm@...ts.linux.dev, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: remove unused average_render_time_in_us
 and i variables

On 3/30/23 20:10, Tom Rix wrote:
> clang with W=1 reports
> drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:1132:15: error: variable
>    'average_render_time_in_us' set but not used [-Werror,-Wunused-but-set-variable]
>          unsigned int average_render_time_in_us = 0;
>                       ^
> This variable is not used so remove it, which caused i to be unused so remove that as well.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Applied, thanks!

> ---
>   .../drm/amd/display/modules/freesync/freesync.c    | 14 --------------
>   1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> index 315da61ee897..5c41a4751db4 100644
> --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> @@ -1129,7 +1129,6 @@ void mod_freesync_handle_preflip(struct mod_freesync *mod_freesync,
>   {
>   	struct core_freesync *core_freesync = NULL;
>   	unsigned int last_render_time_in_us = 0;
> -	unsigned int average_render_time_in_us = 0;
>   
>   	if (mod_freesync == NULL)
>   		return;
> @@ -1138,7 +1137,6 @@ void mod_freesync_handle_preflip(struct mod_freesync *mod_freesync,
>   
>   	if (in_out_vrr->supported &&
>   			in_out_vrr->state == VRR_STATE_ACTIVE_VARIABLE) {
> -		unsigned int i = 0;
>   		unsigned int oldest_index = plane->time.index + 1;
>   
>   		if (oldest_index >= DC_PLANE_UPDATE_TIMES_MAX)
> @@ -1147,18 +1145,6 @@ void mod_freesync_handle_preflip(struct mod_freesync *mod_freesync,
>   		last_render_time_in_us = curr_time_stamp_in_us -
>   				plane->time.prev_update_time_in_us;
>   
> -		/* Sum off all entries except oldest one */
> -		for (i = 0; i < DC_PLANE_UPDATE_TIMES_MAX; i++) {
> -			average_render_time_in_us +=
> -					plane->time.time_elapsed_in_us[i];
> -		}
> -		average_render_time_in_us -=
> -				plane->time.time_elapsed_in_us[oldest_index];
> -
> -		/* Add render time for current flip */
> -		average_render_time_in_us += last_render_time_in_us;
> -		average_render_time_in_us /= DC_PLANE_UPDATE_TIMES_MAX;
> -
>   		if (in_out_vrr->btr.btr_enabled) {
>   			apply_below_the_range(core_freesync,
>   					stream,
-- 
Hamza