linux-kernel - Re: [RFC PATCH v2 3/6] kvm: arm64: Add support for util

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCejXGfh6Hx2NCLi@debian.me>
Date:   Sat, 1 Apr 2023 10:22:04 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     David Dai <davidai@...gle.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Marc Zyngier <maz@...nel.org>,
        Oliver Upton <oliver.upton@...ux.dev>,
        James Morse <james.morse@....com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Zenghui Yu <yuzenghui@...wei.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Sudeep Holla <sudeep.holla@....com>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Valentin Schneider <vschneid@...hat.com>
Cc:     Saravana Kannan <saravanak@...gle.com>, kernel-team@...roid.com,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        kvmarm@...ts.linux.dev
Subject: Re: [RFC PATCH v2 3/6] kvm: arm64: Add support for util_hint service

On Thu, Mar 30, 2023 at 06:43:47PM -0700, David Dai wrote:
> +ARM_SMCCC_HYP_KVM_UTIL_HINT_FUNC_ID
> +    ==============    =========   ============================
> +    Function ID:      (uint32)    0x86000041
> +    Arguments:        (uint32)    util value(0-1024) where 1024 represents
> +                                  the highest performance point normalized
> +                                  across all CPUs
> +    Return values:    (int32)     NOT_SUPPORTED(-1) on error.
> +    Endianness:                   Must be the same endianness
> +                                  as the host.
> +    ==============    ========    ============================

Sphinx reports htmldocs warning:
/home/bagas/repo/linux-kernel/Documentation/virt/kvm/arm/util_hint.rst:21: WARNING: Malformed table.
Column span alignment problem in table line 8.

==============    =========   ============================
Function ID:      (uint32)    0x86000041
Arguments:        (uint32)    util value(0-1024) where 1024 represents
                              the highest performance point normalized
                              across all CPUs
Return values:    (int32)     NOT_SUPPORTED(-1) on error.
Endianness:                   Must be the same endianness
                              as the host.
==============    ========    ============================

I have to fix the table:

---- >8 ----
diff --git a/Documentation/virt/kvm/arm/util_hint.rst b/Documentation/virt/kvm/arm/util_hint.rst
index 262d142d62d91e..99e5bf99446d90 100644
--- a/Documentation/virt/kvm/arm/util_hint.rst
+++ b/Documentation/virt/kvm/arm/util_hint.rst
@@ -11,7 +11,8 @@ to the host.
 This hypercall using the SMC32/HVC32 calling convention:
 
 ARM_SMCCC_HYP_KVM_UTIL_HINT_FUNC_ID
-    ==============    =========   ============================
+
+    ==============    =========   ========================================
     Function ID:      (uint32)    0x86000041
     Arguments:        (uint32)    util value(0-1024) where 1024 represents
                                   the highest performance point normalized
@@ -19,4 +20,4 @@ ARM_SMCCC_HYP_KVM_UTIL_HINT_FUNC_ID
     Return values:    (int32)     NOT_SUPPORTED(-1) on error.
     Endianness:                   Must be the same endianness
                                   as the host.
-    ==============    ========    ============================
+    ==============    =========   ========================================

Thanks.

-- 
An old man doll... just what I always wanted! - Clara