linux-kernel - Re: [PATCH v7 00/10] livepatch: klp-convert tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d28af49-ff04-417c-9047-fc2c796a5040@p183>
Date:   Sat, 1 Apr 2023 12:59:24 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     Joe Lawrence <joe.lawrence@...hat.com>
Cc:     live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kbuild@...r.kernel.org, Josh Poimboeuf <jpoimboe@...nel.org>,
        Miroslav Benes <mbenes@...e.cz>,
        Petr Mladek <pmladek@...e.com>,
        Marcos Paulo de Souza <mpdesouza@...e.com>
Subject: Re: [PATCH v7 00/10] livepatch: klp-convert tool

On Fri, Mar 31, 2023 at 12:03:52PM -0400, Joe Lawrence wrote:
> On 3/30/23 13:04, Alexey Dobriyan wrote:
> > This patchset somehow breaks the build of the simplest livepatch module:
> > 
> > 	make -f linux/linux-1/scripts/Makefile.modfinal
> > 	make[1]: *** No rule to make target 'linux/module-klp/main.tmp.ko', needed by 'linux/module-klp/main.ko'.  Stop.
> > 
> 
> Thanks for testing.
> 
> Presumably this is an out-of-tree livepatch module?  If so, that is
> still on the TODO list.  If not, that is weird as the patchset itself
> includes updates to samples/ and lib/ livepatches that build and load fine.

Yes, this is external module.

make doesn't see this implicit rule despite it is hiding in the open:

	+%.tmp.ko: %.o %.mod.o symbols.klp FORCE
	+	+$(call if_changed,ld_ko_o)