linux-kernel - Re: [PATCH 3/3] of: address: Reshuffle to remove forward declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 1 Apr 2023 15:31:43 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Frank Rowand <frowand.list@...il.com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] of: address: Reshuffle to remove forward declarations

Hi Rob,

On Fri, Mar 31, 2023 at 6:28 PM Rob Herring <robh+dt@...nel.org> wrote:
> On Fri, Mar 31, 2023 at 2:52 AM Geert Uytterhoeven
> <geert+renesas@...der.be> wrote:
> > Reshuffle the code to get rid of the forward declarations, which
> > improves readability.
>
> Is git blame smart enough to ignore this move? If not, I'd rather keep
> the blame than save 3 lines.

Apparently (I didn't know before ;-), it is, when using the -M option:

$ git blame -- drivers/of/address.c | tail -3
1db096f9167bc267e (Geert Uytterhoeven        2023-03-30 13:42:05 +0200
1150) return mem;
1db096f9167bc267e (Geert Uytterhoeven        2023-03-30 13:42:05 +0200 1151) }
1db096f9167bc267e (Geert Uytterhoeven        2023-03-30 13:42:05 +0200
1152) EXPORT_SYMBOL(of_io_request_and_map);

$ git blame -M -- drivers/of/address.c | tail -3
efd342fb0031a1775 (Matthias Brugger          2014-07-18 11:36:39 +0200
1150) return mem;
efd342fb0031a1775 (Matthias Brugger          2014-07-18 11:36:39 +0200 1151) }
efd342fb0031a1775 (Matthias Brugger          2014-07-18 11:36:39 +0200
1152) EXPORT_SYMBOL(of_io_request_and_map);

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds