linux-kernel - Re: [PATCH] fpga: xilinx-pr-decoupler: select FPGA_BRIDGE for 'Xilinx LogiCORE PR Decoupler'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 1 Apr 2023 21:52:45 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Nava kishore Manne <nava.kishore.manne@....com>
Cc:     mdf@...nel.org, hao.wu@...el.com, trix@...hat.com,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: select FPGA_BRIDGE for
 'Xilinx LogiCORE PR Decoupler'

On 2023-03-27 at 17:21:03 +0530, Nava kishore Manne wrote:
> The Xilinx LogiCORE PR Decoupler depends on the FPGA_BRIDGE always and
> hence select it explicitly to make sure that it will be available all
> the time when PR decoupler is enabled.

FPGA_BRIDGE is available all the time if XILINX_PR_DECOUPLER is selected
by user. What's the problem now?

Thanks,
Yilun

> 
> Signed-off-by: Nava kishore Manne <nava.kishore.manne@....com>
> ---
>  drivers/fpga/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 0a00763b9f28..71003f256c60 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -115,8 +115,8 @@ config ALTERA_FREEZE_BRIDGE
>  
>  config XILINX_PR_DECOUPLER
>  	tristate "Xilinx LogiCORE PR Decoupler"
> -	depends on FPGA_BRIDGE
>  	depends on HAS_IOMEM
> +	select FPGA_BRIDGE
>  	help
>  	  Say Y to enable drivers for Xilinx LogiCORE PR Decoupler
>  	  or Xilinx Dynamic Function eXchange AIX Shutdown Manager.
> -- 
> 2.25.1
>