linux-kernel - Re: [PATCH] fs/9p: Rework cache modes and add new options to Documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Apr 2023 08:37:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Eric Van Hensbergen <ericvh@...nel.org>,
        Latchesar Ionkov <lucho@...kov.net>,
        Dominique Martinet <asmadeus@...ewreck.org>,
        Christian Schoenebeck <linux_oss@...debyte.com>,
        v9fs@...ts.linux.dev
Cc:     oe-kbuild-all@...ts.linux.dev,
        v9fs-developer@...ts.sourceforge.net, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Eric Van Hensbergen <ericvh@...nel.org>
Subject: Re: [PATCH] fs/9p: Rework cache modes and add new options to
 Documentation

Hi Eric,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 1543b4c5071c54d76aad7a7a26a6e43082269b0c]

url:    https://github.com/intel-lab-lkp/linux/commits/Eric-Van-Hensbergen/fs-9p-Rework-cache-modes-and-add-new-options-to-Documentation/20230402-071815
base:   1543b4c5071c54d76aad7a7a26a6e43082269b0c
patch link:    https://lore.kernel.org/r/20230401-ericvh-dev-rework-cache-options-v1-1-12d3adbdd33a%40kernel.org
patch subject: [PATCH] fs/9p: Rework cache modes and add new options to Documentation
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230402/202304020858.JARvGo8W-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/8d563b947e70b7fe9a067ef3be10471a05452505
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Eric-Van-Hensbergen/fs-9p-Rework-cache-modes-and-add-new-options-to-Documentation/20230402-071815
        git checkout 8d563b947e70b7fe9a067ef3be10471a05452505
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/9p/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304020858.JARvGo8W-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/9p/vfs_inode.c: In function 'v9fs_evict_inode':
>> fs/9p/vfs_inode.c:375:16: warning: variable 'version' set but not used [-Wunused-but-set-variable]
     375 |         __le32 version;
         |                ^~~~~~~
   fs/9p/vfs_inode.c: In function 'v9fs_vfs_atomic_open':
>> fs/9p/vfs_inode.c:799:28: warning: variable 'v9inode' set but not used [-Wunused-but-set-variable]
     799 |         struct v9fs_inode *v9inode;
         |                            ^~~~~~~
--
   fs/9p/vfs_inode_dotl.c: In function 'v9fs_vfs_setattr_dotl':
>> fs/9p/vfs_inode_dotl.c:541:35: warning: variable 'v9ses' set but not used [-Wunused-but-set-variable]
     541 |         struct v9fs_session_info *v9ses;
         |                                   ^~~~~


vim +/version +375 fs/9p/vfs_inode.c

2bad8471511ce5 Eric Van Hensbergen 2005-09-09  366  
60e78d2c993e58 Abhishek Kulkarni   2009-09-23  367  /**
bc868036569e1d David Howells       2021-10-04  368   * v9fs_evict_inode - Remove an inode from the inode cache
60e78d2c993e58 Abhishek Kulkarni   2009-09-23  369   * @inode: inode to release
60e78d2c993e58 Abhishek Kulkarni   2009-09-23  370   *
60e78d2c993e58 Abhishek Kulkarni   2009-09-23  371   */
b57922d97fd6f7 Al Viro             2010-06-07  372  void v9fs_evict_inode(struct inode *inode)
60e78d2c993e58 Abhishek Kulkarni   2009-09-23  373  {
6b39f6d22fbf67 Aneesh Kumar K.V    2011-02-28  374  	struct v9fs_inode *v9inode = V9FS_I(inode);
93c846143d8630 David Howells       2020-11-18 @375  	__le32 version;
6b39f6d22fbf67 Aneesh Kumar K.V    2011-02-28  376  
4ad78628445d26 Al Viro             2015-12-08  377  	truncate_inode_pages_final(&inode->i_data);
93c846143d8630 David Howells       2020-11-18  378  	version = cpu_to_le32(v9inode->qid.version);
8d563b947e70b7 Eric Van Hensbergen 2023-04-01  379  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests