linux-kernel - Re: [PATCH] drm/lima/lima_drv: Add missing unwind goto in lima_pdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 2 Apr 2023 18:22:07 +0800
From:   Qiang Yu <yuq825@...il.com>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc:     error27@...il.com, David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>, Eric Anholt <eric@...olt.net>,
        Andreas Baierl <ichgeh@...reisrum.de>,
        Simon Shields <simon@...eageos.org>,
        Heiko Stuebner <heiko@...ech.de>,
        dri-devel@...ts.freedesktop.org, lima@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/lima/lima_drv: Add missing unwind goto in lima_pdev_probe()

Applied to drm-misc-next.

On Tue, Mar 14, 2023 at 2:22 PM Qiang Yu <yuq825@...il.com> wrote:
>
> Reviewed-by: Qiang Yu <yuq825@...il.com>
>
> On Tue, Mar 14, 2023 at 1:27 PM Harshit Mogalapalli
> <harshit.m.mogalapalli@...cle.com> wrote:
> >
> > Smatch reports:
> > drivers/gpu/drm/lima/lima_drv.c:396 lima_pdev_probe() warn:
> >         missing unwind goto?
> >
> > Store return value in err and goto 'err_out0' which has
> > lima_sched_slab_fini() before returning.
> >
> > Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
> > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> > ---
> > Only compile tested.
> > ---
> >  drivers/gpu/drm/lima/lima_drv.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/lima/lima_drv.c b/drivers/gpu/drm/lima/lima_drv.c
> > index 7b8d7178d09a..39cab4a55f57 100644
> > --- a/drivers/gpu/drm/lima/lima_drv.c
> > +++ b/drivers/gpu/drm/lima/lima_drv.c
> > @@ -392,8 +392,10 @@ static int lima_pdev_probe(struct platform_device *pdev)
> >
> >         /* Allocate and initialize the DRM device. */
> >         ddev = drm_dev_alloc(&lima_drm_driver, &pdev->dev);
> > -       if (IS_ERR(ddev))
> > -               return PTR_ERR(ddev);
> > +       if (IS_ERR(ddev)) {
> > +               err = PTR_ERR(ddev);
> > +               goto err_out0;
> > +       }
> >
> >         ddev->dev_private = ldev;
> >         ldev->ddev = ddev;
> > --
> > 2.38.1
> >