linux-kernel - Re: [PATCH] Input: cma3000_d0x - Clean up some inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZCjecTFJKnsiwJmT@google.com>
Date:   Sat, 1 Apr 2023 18:46:25 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] Input: cma3000_d0x - Clean up some inconsistent indenting

Hi Jiapeng,

On Wed, Mar 22, 2023 at 02:41:58PM +0800, Jiapeng Chong wrote:
> No functional modification involved.
> 
> drivers/input/misc/cma3000_d0x.c:328 cma3000_init() warn: inconsistent indenting.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4588
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/input/misc/cma3000_d0x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c
> index e6feb73bb52b..c444a44e4576 100644
> --- a/drivers/input/misc/cma3000_d0x.c
> +++ b/drivers/input/misc/cma3000_d0x.c
> @@ -325,7 +325,7 @@ struct cma3000_accl_data *cma3000_init(struct device *dev, int irq,
>  	input_dev->open = cma3000_open;
>  	input_dev->close = cma3000_close;
>  
> -	 __set_bit(EV_ABS, input_dev->evbit);
> +	__set_bit(EV_ABS, input_dev->evbit);

We should simply remove this, as input_set_abs_params() will set EV_ABS
bit for us.

>  
>  	input_set_abs_params(input_dev, ABS_X,
>  			-data->g_range, data->g_range, pdata->fuzz_x, 0);
> -- 
> 2.20.1.7.g153144c
> 

Thanks.

-- 
Dmitry