linux-kernel - Re: [PATCH] iommu/amd: Fix "Guest Virtual APIC Table Root Pointer" configuration in IRTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <575ef405-9d43-b99c-cae7-f88cfd6063e2@amd.com>
Date:   Mon, 3 Apr 2023 11:29:13 +0700
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@....com>
To:     Kishon Vijay Abraham I <kvijayab@....com>,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>
Cc:     Vasant Hegde <vasant.hegde@....com>,
        Santosh Shukla <santosh.shukla@....com>,
        "Nikunj A . Dadhania" <nikunj@....com>, iommu@...ts.linux.dev,
        linux-kernel@...r.kernel.org, joao.m.martins@...cle.com,
        boris.ostrovsky@...cle.com, alejandro.j.jimenez@...cle.com
Subject: Re: [PATCH] iommu/amd: Fix "Guest Virtual APIC Table Root Pointer"
 configuration in IRTE

Kishon,

On 3/31/2023 1:17 PM, Kishon Vijay Abraham I wrote:
> commit b9c6ff94e43a ("iommu/amd: Re-factor guest virtual APIC
> (de-)activation code") while refactoring guest virtual APIC
> activation/de-activation code, stored information for activate/de-activate
> in "struct amd_ir_data". It used 32-bit integer data type for storing the
> "Guest Virtual APIC Table Root Pointer" (ga_root_ptr), though the
> "ga_root_ptr" is actually a 40-bit field in IRTE (Interrupt Remapping
> Table Entry).
> 
> This causes interrupts from PCIe devices to not reach the guest in the case
> of PCIe passthrough with SME (Secure Memory Encryption) enabled as _SME_
> bit in the "ga_root_ptr" is lost before writing it to the IRTE.
> 
> Fix it by using 64-bit data type for storing the "ga_root_ptr".
> 
> Fixes: b9c6ff94e43a ("iommu/amd: Re-factor guest virtual APIC (de-)activation code")
> Cc: stable@...r.kernel.org # v5.4+
> Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> Signed-off-by: Kishon Vijay Abraham I <kvijayab@....com>

Please also add
Reported-by: Alejandro Jimenez <alejandro.j.jimenez@...cle.com>

Thanks,
Suravee