[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a657284f-a408-48a8-b294-0add65b3e2a2@sirena.org.uk>
Date: Mon, 3 Apr 2023 19:28:17 +0100
From: Mark Brown <broonie@...nel.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Devi Priya <quic_devipriy@...cinc.com>, agross@...nel.org,
andersson@...nel.org, lgirdwood@...il.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
quic_srichara@...cinc.com, quic_gokulsri@...cinc.com,
quic_sjaganat@...cinc.com, quic_kathirav@...cinc.com,
quic_arajkuma@...cinc.com, quic_anusha@...cinc.com,
quic_ipkumar@...cinc.com
Subject: Re: [PATCH V2 4/6] regulator: qcom_smd: Add support to define the
bootup voltage
On Mon, Apr 03, 2023 at 08:21:25PM +0200, Konrad Dybcio wrote:
> On 3.04.2023 20:14, Mark Brown wrote:
> > than up to the minimum. The driver could also look at the constraints
> > when guessing at the hardware configuration rather than claiming an out
> > of spec voltage, this would mean we wouldn't need to correct anything.
> Hm, all of what you said sounds like a valid concern.. And then we
> probably shouldn't shoot up to max by default, as going too low is
> not going to cause as much potential irreversible damage as going
> too high.. Especially with programmer error..
It sounds like the driver should just be reporting a value which is at
least within the constraints.
> Too bad Qualcomm's firmware architecture doesn't allow for reading
> back the voltage..
Right, their interfaces here have some serious drawbacks.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists