linux-kernel - Re: [PATCH] soc: bcm: brcmstb: biuctrl: fix of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230403203725.906166-1-f.fainelli@gmail.com>
Date:   Mon,  3 Apr 2023 13:37:25 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     bcm-kernel-feedback-list@...adcom.com,
        Zhaoyang Li <lizhaoyang04@...t.edu.cn>
Cc:     hust-os-kernel-patches@...glegroups.com,
        Dan Carpenter <error27@...il.com>,
        Dongliang Mu <dzm91@...t.edu.cn>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: bcm: brcmstb: biuctrl: fix of_iomap leak

On Mon, 27 Mar 2023 19:54:22 +0800, Zhaoyang Li <lizhaoyang04@...t.edu.cn> wrote:
> Smatch reports:
> 
> drivers/soc/bcm/brcmstb/biuctrl.c:291 setup_hifcpubiuctrl_regs() warn:
> 'cpubiuctrl_base' from of_iomap() not released on lines: 291.
> 
> This is because in setup_hifcpubiuctrl_regs(),
> cpubiuctrl_base is not released when handle error, which may cause a leak.
> To fix this, iounmap is added when handle error.
> 
> Fixes: 22f7a9116eba ("soc: brcmstb: Correct CPU_CREDIT_REG offset for Brahma-B53 CPUs")
> Signed-off-by: Zhaoyang Li <lizhaoyang04@...t.edu.cn>
> Reviewed-by: Dan Carpenter <error27@...il.com>
> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks!
--
Florian