linux-kernel - Re: [PATCH v2] selftests/clone3: fix number of tests in ksft_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230403205735.ltb3pmh5yl2pjzhu@distanz.ch>
Date:   Mon, 3 Apr 2023 22:57:37 +0200
From:   Tobias Klauser <tklauser@...tanz.ch>
To:     Christian Brauner <brauner@...nel.org>,
        Shuah Khan <shuah@...nel.org>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] selftests/clone3: fix number of tests in ksft_set_plan

On 2023-03-14 at 14:09:59 +0100, Christian Brauner <brauner@...nel.org> wrote:
> On Tue, Mar 14, 2023 at 01:34:14PM +0100, Tobias Klauser wrote:
> > Commit 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME")
> > added an additional test, so the number passed to ksft_set_plan needs to
> > be bumped accordingly.
> > 
> > Also use ksft_finished() to print results and exit. This will catch future
> > mismatches between ksft_set_plan() and the number of tests being run.
> > 
> > Fixes: 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME")
> > Cc: Christian Brauner <brauner@...nel.org>
> > Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> > ---
> 
> Looks good. Thanks for fixing this,
> Reviewed-by: Christian Brauner <brauner@...nel.org>
> 
> Feel free to take this through the selftests tree, Shuah.

It looks like this hasn't made it into Linus' tree yet and I also don't
see it in Shuah's tree. Would it be possible to still submit this for
6.3-rc6 given the commit it fixes has made it to Linus' tree already?

Thanks