linux-kernel - Re: [PATCH v3 09/11] scsi: scsi_debug: Use scsi_host_busy() in delay_store() and ndelay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40fbe93a-c39f-9887-2fe7-93532fee4771@interlog.com>
Date:   Mon, 3 Apr 2023 01:21:38 -0400
From:   Douglas Gilbert <dgilbert@...erlog.com>
To:     John Garry <john.g.garry@...cle.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        bvanassche@....org
Subject: Re: [PATCH v3 09/11] scsi: scsi_debug: Use scsi_host_busy() in
 delay_store() and ndelay_store()

On 2023-03-27 03:43, John Garry wrote:
> The functions to update ndelay and delay value first check whether we have
> any in-flight IO for any host. It does this by checking if any tag is used
> in the global submit queues.
> 
> We can achieve the same by setting the host as blocked and then ensuring
> that we have no in-flight commands with scsi_host_busy().
> 
> Note that scsi_host_busy() checks SCMD_STATE_INFLIGHT flag, which is only
> set per command after we ensure that the host is not blocked, i.e. we
> see more commands active after the check for scsi_host_busy() returns 0.
> 
> Signed-off-by: John Garry <john.g.garry@...cle.com>
Acked-by: Douglas Gilbert <dgilbert@...erlog.com>

Thanks.