linux-kernel - Re: [PATCH v5 3/3] gpio: ws16c48: Migrate to the regmap API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6399e7d7-d748-4b97-bf60-99df2b29ed70@sirena.org.uk>
Date:   Mon, 3 Apr 2023 23:25:06 +0100
From:   Mark Brown <broonie@...nel.org>
To:     William Breathitt Gray <william.gray@...aro.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        techsupport@...systems.com,
        Paul Demetrotion <pdemetrotion@...systems.com>,
        Michael Walle <michael@...le.cc>
Subject: Re: [PATCH v5 3/3] gpio: ws16c48: Migrate to the regmap API

On Mon, Apr 03, 2023 at 06:20:56PM -0400, William Breathitt Gray wrote:
> On Mon, Apr 03, 2023 at 10:12:44PM +0100, Mark Brown wrote:

> > The above doesn't configure the regmap locking so you'll have a spinlock
> > by default (MMIO being a fast bus).

> You're right, it'll be a spinlock in this case and not mutex.
> Unfortunately, we'll still need to change that to avoid deadlocks on -rt
> kernels [0].

My point is that you haven't actually done that.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)