linux-kernel - Re: [RFC PATCH v3] nubus: Don't list slot resources by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e887a8c9-4310-a6cb-62d2-39db7d75d452@linux-m68k.org>
Date:   Tue, 4 Apr 2023 08:50:59 +1000 (AEST)
From:   Finn Thain <fthain@...ux-m68k.org>
To:     Brad Boyer <flar@...andria.com>
cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v3] nubus: Don't list slot resources by default

On Sun, 2 Apr 2023, Brad Boyer wrote:

> On Sun, Mar 26, 2023 at 02:37:02PM +1100, Finn Thain wrote:
> > diff --git a/drivers/nubus/nubus.c b/drivers/nubus/nubus.c
> > index f70ba58dbc55..d2d2b580f646 100644
> > --- a/drivers/nubus/nubus.c
> > +++ b/drivers/nubus/nubus.c
> > @@ -32,6 +32,12 @@
> >  
> >  /* Globals */
> >  
> > +/* This parameter makes slot resources available in procfs. It's deprecated and
> > + * disabled by default as procfs is no longer thought to be suitable for that.
> > + */
> > +bool populate_procfs;
> > +module_param(populate_procfs, bool, 0);
> > +
> >  LIST_HEAD(nubus_func_rsrcs);
> >  
> >  /* Meaning of "bytelanes":
> 
> Would it be better to give this option a name that indicates that it is 
> for nubus only? These are effectively a global namespace. Other than 
> this, I don't see any issues.
> 

The name of the module here is "nubus", so this parameter is specified as 
"nubus.populate_procfs" in the kernel parameters. Without the "nubus" it 
doesn't work. I should probably add a comment about that.