linux-kernel - Re: [PATCH] iommu/exynos: Use the devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f324b20-6710-4612-d78a-ea294ad283aa@samsung.com>
Date:   Mon, 3 Apr 2023 09:03:54 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        iommu@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH] iommu/exynos: Use the devm_clk_get_optional() helper

On 26.03.2023 14:37, Christophe JAILLET wrote:
> Use devm_clk_get_optional() instead of hand writing it.
> This saves some loC and improves the semantic.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Acked-by: Marek Szyprowski <m.szyprowski@...sung.com>
> ---
>   drivers/iommu/exynos-iommu.c | 24 ++++++++----------------
>   1 file changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> index 483aaaeb6dae..867f409e0325 100644
> --- a/drivers/iommu/exynos-iommu.c
> +++ b/drivers/iommu/exynos-iommu.c
> @@ -747,22 +747,16 @@ static int exynos_sysmmu_probe(struct platform_device *pdev)
>   		return ret;
>   	}
>   
> -	data->clk = devm_clk_get(dev, "sysmmu");
> -	if (PTR_ERR(data->clk) == -ENOENT)
> -		data->clk = NULL;
> -	else if (IS_ERR(data->clk))
> +	data->clk = devm_clk_get_optional(dev, "sysmmu");
> +	if (IS_ERR(data->clk))
>   		return PTR_ERR(data->clk);
>   
> -	data->aclk = devm_clk_get(dev, "aclk");
> -	if (PTR_ERR(data->aclk) == -ENOENT)
> -		data->aclk = NULL;
> -	else if (IS_ERR(data->aclk))
> +	data->aclk = devm_clk_get_optional(dev, "aclk");
> +	if (IS_ERR(data->aclk))
>   		return PTR_ERR(data->aclk);
>   
> -	data->pclk = devm_clk_get(dev, "pclk");
> -	if (PTR_ERR(data->pclk) == -ENOENT)
> -		data->pclk = NULL;
> -	else if (IS_ERR(data->pclk))
> +	data->pclk = devm_clk_get_optional(dev, "pclk");
> +	if (IS_ERR(data->pclk))
>   		return PTR_ERR(data->pclk);
>   
>   	if (!data->clk && (!data->aclk || !data->pclk)) {
> @@ -770,10 +764,8 @@ static int exynos_sysmmu_probe(struct platform_device *pdev)
>   		return -ENOSYS;
>   	}
>   
> -	data->clk_master = devm_clk_get(dev, "master");
> -	if (PTR_ERR(data->clk_master) == -ENOENT)
> -		data->clk_master = NULL;
> -	else if (IS_ERR(data->clk_master))
> +	data->clk_master = devm_clk_get_optional(dev, "master");
> +	if (IS_ERR(data->clk_master))
>   		return PTR_ERR(data->clk_master);
>   
>   	data->sysmmu = dev;

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland