linux-kernel - Re: [PATCH] soc: renesas: renesas-soc: release 'chipid' from ioremap()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2023 09:46:09 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Dan Carpenter <error27@...il.com>
Cc:     Li Yang <lidaxian@...t.edu.cn>,
        Magnus Damm <magnus.damm@...il.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Biju Das <biju.das.jz@...renesas.com>,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: renesas: renesas-soc: release 'chipid' from ioremap()

Hi Dan,

On Mon, Apr 3, 2023 at 9:34 AM Dan Carpenter <error27@...il.com> wrote:
> On Mon, Apr 03, 2023 at 09:12:55AM +0200, Geert Uytterhoeven wrote:
> > Perhaps we need a different mechanism to annotate error handling code
> > that cannot ever happen in a real product, so it can be thrown away by
> > the compiler, while still pleasing the static checkers?  All these
> > checks and error handling code do affect kernel size.  There are
> > Linux products running on SoCs with 8 MiB of internal SRAM.
>
> People sometimes call BUG_ON(!soc_dev_attr).  It's sort of rare these

BUG_ON() is also not cheap, space-wise (except if CONFIG_BUG=n).

> days.  It would be easy to make a function which silences Smatch...
>
>         __system_is_dead();

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds