linux-kernel - Re: [PATCH 0/2] improve arche_platform_wd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <642a1f88bd232_394c38294a5@iweiny-mobl.notmuch>
Date:   Sun, 2 Apr 2023 17:36:24 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>,
        <outreachy@...ts.linux.dev>
CC:     <hvaibhav.linux@...il.com>, <johan@...nel.org>, <elder@...nel.org>,
        <gregkh@...uxfoundation.org>, <greybus-dev@...ts.linaro.org>,
        <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] improve arche_platform_wd_irq() function

Khadija Kamran wrote:
> Improve arche_platform_wd_irq() function to minimize indentation and fix
> checkpatch issues.

Minor point but the cover should have

'staging: greybus: ...'

... for the subject.

The function name is nice but it is a pain to look in the code to know
what part of the kernel this series is for.

Ira

> 
> Khadija Kamran (2):
>   staging: greybus: add a single exit path to arche_platform_wd_irq()
>   staging: greybus: refactor arche_platform_wd_irq()
> 
>  drivers/staging/greybus/arche-platform.c | 84 ++++++++++++------------
>  1 file changed, 43 insertions(+), 41 deletions(-)
> 
> -- 
> 2.34.1
> 
>