linux-kernel - Re: [PATCH] perf/arm-cmn: fix regitster offset of CMN_MXP__CONNECT_INFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d232392a-dadb-ec53-9613-d9b561fe1e87@arm.com>
Date:   Mon, 3 Apr 2023 10:40:11 +0100
From:   Robin Murphy <robin.murphy@....com>
To:     Mark Rutland <mark.rutland@....com>
Cc:     Jing Zhang <renyu.zj@...ux.alibaba.com>,
        Ilkka Koskinen <ilkka@...amperecomputing.com>,
        Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-perf-users@...r.kernel.org,
        Shuai Xue <xueshuai@...ux.alibaba.com>,
        Zhuo Song <zhuo.song@...ux.alibaba.com>,
        Ruidong Tian <tianruidong@...ux.alibaba.com>
Subject: Re: [PATCH] perf/arm-cmn: fix regitster offset of
 CMN_MXP__CONNECT_INFO_P2-5

On 2023-04-03 08:45, Mark Rutland wrote:
> On Thu, Mar 30, 2023 at 11:34:22AM +0100, Robin Murphy wrote:
>> On 2023-03-30 10:47, Jing Zhang wrote:
>>> In the CMN700 specification, it is described that the address offset
>>> of the mxp_device_connect_info_p0-5 register is 16'h8 + #{8*index}.
>>> Therefore, the address offset of the CMN_MXP__CONNECT_INFO_P2-5 macro
>>> defined in the code is wrong, which causes the cmn700 topology map
>>> incorrect printed in debugfs.
>>>
>>> So correct the address offset value to make the cmn700 topology map
>>> correct in debugfs.
>>>
>>> Fixes: 60d1504070c2 ("perf/arm-cmn: Support new IP features")
>>
>> Ugh, these offsets are correct for CI-700, so strictly that commit is fine.
>> What I failed to notice is that CMN-700 shuffled the mesh_port_connect_info
>> registers out of the way, so it's commit 23760a014417 which should have
>> added more handling for this difference.
> 
> I'm assuming that means that this patch breaks !CMN-700 ?
> 
> i.e. a more substantial fix is necessary, and it's not just a matter of
> changing the Fixes tag.

Yes, indeed. I have half an idea, and the plan for this week was to work 
on other CMN stuff anyway, so I'll see what I can cook up.

Cheers,
Robin.