[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230403121813.55c8aa2a@aktux>
Date: Mon, 3 Apr 2023 12:18:13 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: robh+dt@...nel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Tony Lindgren <tony@...mide.com>,
Andrew Davis <afd@...com>
Subject: Re: [PATCH v3 1/2] dt-bindings: omap: Convert omap.txt to yaml
Hi,
On Sun, 2 Apr 2023 13:26:46 +0200
Krzysztof Kozlowski <krzk@...nel.org> wrote:
> On 01/04/2023 16:02, Andreas Kemnade wrote:
> > From: Andrew Davis <afd@...com>
> >
> > Convert omap.txt to yaml.
> >
> > Signed-off-by: Andrew Davis <afd@...com>
> > [various cleanup, adding Epson Moverio BT-200]
> > Signed-off-by: Andreas Kemnade <andreas@...nade.info>
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Your CC list is broken in few ways. Just use the script, don't re-invent
> the addresses.
>
well, I am using the script and added a few adresses obviously missing.
But maybe I have used the script from an older kernel. The patch was against
linux-next.
[...]
> > + - description: TI DRA7 SoC based platforms
> > + items:
> > + - enum:
> > + - ti,dra718-evm
>
> This is not correct. Maybe you forgot to fix DTS, but anyway it's
> confusing to have dra718-evm with dra768 SoC. Is this really proper
> combination?
>
dra718-evm has a lot of compatibles, no idea if that is sane.
And to better discuss such things I added the omap mailinglist (with a typo,
sorry). To avoid that trouble in the future, I added a patch to MAINTAINERS.
But I think it is better to not convert dra7 stuff for now, then
it can be discussed by the right people.
Regards,
Andreas
Powered by blists - more mailing lists