linux-kernel - [PATCH 2/2] Input: st1232 - add wake up event counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon,  3 Apr 2023 14:47:07 +0200
From:   Javier Carrasco <javier.carrasco@...fvision.net>
To:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Uwe Kleine-g <u.kleine-koenig@...gutronix.de>,
        Michael Riesch <michael.riesch@...fvision.net>,
        Javier Carrasco <javier.carrasco@...fvision.net>
Subject: [PATCH 2/2] Input: st1232 - add wake up event counting

This device driver provides wakeup capabilities but the wakeup events
are not reflected in sysfs. Add pm_wakeup_event to the interrupt handler
in order to do so.

Signed-off-by: Javier Carrasco <javier.carrasco@...fvision.net>
---
 drivers/input/touchscreen/st1232.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/input/touchscreen/st1232.c b/drivers/input/touchscreen/st1232.c
index faa0be3993f4..f175bea464e1 100644
--- a/drivers/input/touchscreen/st1232.c
+++ b/drivers/input/touchscreen/st1232.c
@@ -59,6 +59,7 @@ struct st1232_ts_data {
 	const struct st_chip_info *chip_info;
 	int read_buf_len;
 	u8 *read_buf;
+	bool suspended;
 };
 
 static int st1232_ts_read_data(struct st1232_ts_data *ts, u8 reg,
@@ -173,9 +174,13 @@ static int st1232_ts_parse_and_report(struct st1232_ts_data *ts)
 static irqreturn_t st1232_ts_irq_handler(int irq, void *dev_id)
 {
 	struct st1232_ts_data *ts = dev_id;
+	struct i2c_client *client = ts->client;
 	int count;
 	int error;
 
+	if (ts->suspended && device_may_wakeup(&client->dev))
+		pm_wakeup_event(&client->dev, 0);
+
 	error = st1232_ts_read_data(ts, REG_XY_COORDINATES, ts->read_buf_len);
 	if (error)
 		goto out;
@@ -344,10 +349,16 @@ static int st1232_ts_suspend(struct device *dev)
 {
 	struct i2c_client *client = to_i2c_client(dev);
 	struct st1232_ts_data *ts = i2c_get_clientdata(client);
+	struct input_dev *input = ts->input_dev;
+
+	mutex_lock(&input->mutex);
+	ts->suspended = true;
 
 	if (!device_may_wakeup(&client->dev))
 		st1232_ts_power(ts, false);
 
+	mutex_unlock(&input->mutex);
+
 	return 0;
 }
 
@@ -355,10 +366,16 @@ static int st1232_ts_resume(struct device *dev)
 {
 	struct i2c_client *client = to_i2c_client(dev);
 	struct st1232_ts_data *ts = i2c_get_clientdata(client);
+	struct input_dev *input = ts->input_dev;
+
+	mutex_lock(&input->mutex);
+	ts->suspended = false;
 
 	if (!device_may_wakeup(&client->dev))
 		st1232_ts_power(ts, true);
 
+	mutex_unlock(&input->mutex);
+
 	return 0;
 }
 
-- 
2.37.2