linux-kernel - Re: [PATCH v2 4.19/5.4/5.10 1/1] gfs2: Always check inode size of inline inodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2023 15:27:11 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Fedor Pchelkin <pchelkin@...ras.ru>
Cc:     stable@...r.kernel.org, Andreas Gruenbacher <agruenba@...hat.com>,
        cluster-devel@...hat.com, linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        lvc-project@...uxtesting.org,
        syzbot+7bb81dfa9cda07d9cd9d@...kaller.appspotmail.com
Subject: Re: [PATCH v2 4.19/5.4/5.10 1/1] gfs2: Always check inode size of
 inline inodes

On Fri, Mar 24, 2023 at 11:26:15PM +0300, Fedor Pchelkin wrote:
> From: Andreas Gruenbacher <agruenba@...hat.com>
> 
> commit 70376c7ff31221f1d21db5611d8209e677781d3a upstream.
> 
> Check if the inode size of stuffed (inline) inodes is within the allowed
> range when reading inodes from disk (gfs2_dinode_in()).  This prevents
> us from on-disk corruption.
> 
> The two checks in stuffed_readpage() and gfs2_unstuffer_page() that just
> truncate inline data to the maximum allowed size don't actually make
> sense, and they can be removed now as well.
> 
> Reported-by: syzbot+7bb81dfa9cda07d9cd9d@...kaller.appspotmail.com
> Signed-off-by: Andreas Gruenbacher <agruenba@...hat.com>
> [pchelkin@...ras.ru: adjust the inode variable inside gfs2_dinode_in with
> the format used before upstream commit 7db354444ad8 ("gfs2: Cosmetic
> gfs2_dinode_{in,out} cleanup")]
> Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>
> ---
> v2: add missed From: tag

Now queued up, thanks.

greg k-h