linux-kernel - Re: [PATCH v1 10/14] extcon: use dev_of_node(dev) instead of dev->of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <496784d9-0e17-1be5-f33b-3fefa5c4ede4@gmail.com>
Date:   Mon, 3 Apr 2023 23:17:40 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bumwoo Lee <bw365.lee@...sung.com>,
        linux-kernel@...r.kernel.org
Cc:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH v1 10/14] extcon: use dev_of_node(dev) instead of
 dev->of_node

On 23. 3. 22. 23:40, Andy Shevchenko wrote:
> The dev_of_node function should be preferred.
> In the result we may drop unneeded NULL check
> of the pointer to the device object.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/extcon/extcon.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 5cadbfc151e6..32e96cb49067 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -1429,21 +1429,17 @@ struct extcon_dev *extcon_find_edev_by_node(struct device_node *node)
>   */
>  struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index)
>  {
> -	struct device_node *node;
> +	struct device_node *node, *np = dev_of_node(dev);
>  	struct extcon_dev *edev;
>  
> -	if (!dev)
> -		return ERR_PTR(-EINVAL);
> -
> -	if (!dev->of_node) {
> +	if (!np) {
>  		dev_dbg(dev, "device does not have a device node entry\n");
>  		return ERR_PTR(-EINVAL);
>  	}
>  
> -	node = of_parse_phandle(dev->of_node, "extcon", index);
> +	node = of_parse_phandle(np, "extcon", index);
>  	if (!node) {
> -		dev_dbg(dev, "failed to get phandle in %pOF node\n",
> -			dev->of_node);
> +		dev_dbg(dev, "failed to get phandle in %pOF node\n", np);
>  		return ERR_PTR(-ENODEV);
>  	}
>  

Applied it with the following patch title.
Just use capital letter at the beginning char of title

- extcon: Use dev_of_node(dev) instead of dev->of_node

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi