linux-kernel - Re: [PATCH v4 4/6] dts: qcom: arm64: qcom: sdm845: use defines for VMIDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d9d001f14036caf4f6d47448d4d2fdb0b188101.camel@dylanvanassche.be>
Date:   Mon, 03 Apr 2023 17:32:17 +0200
From:   Dylan Van Assche <me@...anvanassche.be>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [PATCH v4 4/6] dts: qcom: arm64: qcom: sdm845: use defines for
 VMIDs

Hi Krzysztof,

On Mon, 2023-04-03 at 11:20 +0200, Krzysztof Kozlowski wrote:
> On 01/04/2023 19:35, Dylan Van Assche wrote:
> > Use VMID defines for SLPI's FastRPC node in the Qualcomm SDM845 DTS
> > instead of hardcoded magic values.
> > 
> > Signed-off-by: Dylan Van Assche <me@...anvanassche.be>
> > ---
> >  arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index 1f25a7f4e02b..dc4b553cbe2e 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -13,6 +13,7 @@
> >  #include <dt-bindings/clock/qcom,rpmh.h>
> >  #include <dt-bindings/clock/qcom,videocc-sdm845.h>
> >  #include <dt-bindings/dma/qcom-gpi.h>
> > +#include <dt-bindings/firmware/qcom,scm.h>
> >  #include <dt-bindings/gpio/gpio.h>
> >  #include <dt-bindings/interconnect/qcom,osm-l3.h>
> >  #include <dt-bindings/interconnect/qcom,sdm845.h>
> > @@ -3372,7 +3373,8 @@ fastrpc {
> >                                         qcom,glink-channels =
> > "fastrpcglink-apps-dsp";
> >                                         label = "sdsp";
> >                                         qcom,non-secure-domain;
> > -                                       qcom,vmids = <0x3 0xF 0x5
> > 0x6>;
> 
> Didn't you just add it in previous patch? Don't add incorrect code
> which
> you immediately change.
> 

Both are similar, the code is in fact the same. I followed what Konrad
suggested in v3 to make a patch on top:

> Please use the recently-introduced header and depend on (and
make a patch atop)

https://lore.kernel.org/linux-devicetree/20230330165322.118279-1-me@dylanvanassche.be/T/#mab3c3421157acb0a4811dad5bb62d7349a9d4008

I can squash this patch in the FastRPC node one, that would make it
disappear. Let me know what you prefer and I will do it in v5 :)

> Best regards,
> Krzysztof
> 

Kind regards,
Dylan Van Assche