linux-kernel - Re: [PATCH] MIPS: vpe-cmp: remove module owner pointer from struct class usage.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230403155804.GA12122@alpha.franken.de>
Date:   Mon, 3 Apr 2023 17:58:04 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        Dengcheng Zhu <dzhu@...ecomp.com>,
        John Crispin <blogic@...nwrt.org>,
        Qais Yousef <Qais.Yousef@...tec.com>,
        "Steven J . Hill" <Steven.Hill@...tec.com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] MIPS: vpe-cmp: remove module owner pointer from struct
 class usage.

On Sun, Apr 02, 2023 at 11:05:45AM +0200, Greg Kroah-Hartman wrote:
> In commit 6e30a66433af ("driver core: class: remove struct module owner
> out of struct class"), the module owner pointer was removed from struct
> class, but this was missed for the mips vpe-cmp code due to lack of
> build testing (and it being burried under a very unused config
> settings.)  Fix this up by removing the module pointer to resolve the
> build error.
> 
> Note, there are other problems with the driver model usage in this file
> (static struct device usage, empty device release function, etc.), so it
> probably could use some good cleaning up, but odds are this driver
> really isn't used so hopefully it will just be removed entirely someday
> soon as part of the general "remove unused arches" cleanup that is
> slowly happening.
> 
> Cc: Dengcheng Zhu <dzhu@...ecomp.com>
> Cc: John Crispin <blogic@...nwrt.org>
> Cc: Qais Yousef <Qais.Yousef@...tec.com>
> Cc: Steven J. Hill <Steven.Hill@...tec.com>
> Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> Cc: Yang Yingliang <yangyingliang@...wei.com>
> Cc: linux-mips@...r.kernel.org
> Reported-by: kernel test robot <lkp@...el.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304020802.xbRTJKjW-lkp@intel.com/
> Fixes: 6e30a66433af ("driver core: class: remove struct module owner out of struct class")
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  arch/mips/kernel/vpe-cmp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/kernel/vpe-cmp.c b/arch/mips/kernel/vpe-cmp.c
> index 92140edb3ce3..4ef7f49a4c6d 100644
> --- a/arch/mips/kernel/vpe-cmp.c
> +++ b/arch/mips/kernel/vpe-cmp.c
> @@ -79,7 +79,6 @@ static void vpe_device_release(struct device *cd)
>  
>  static struct class vpe_class = {
>  	.name = "vpe",
> -	.owner = THIS_MODULE,
>  	.dev_release = vpe_device_release,
>  	.dev_groups = vpe_groups,
>  };
> -- 
> 2.40.0

I guess this should go the same way as commit 6e30a66433af, therefore

Acked-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]