linux-kernel - Re: [PATCH v2] fs/buffer: Remove redundant assignment to err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCr7H9NqkPlmR/jk@casper.infradead.org>
Date:   Mon, 3 Apr 2023 17:13:19 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Christian Brauner <brauner@...nel.org>
Cc:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>, viro@...iv.linux.org.uk
Subject: Re: [PATCH v2] fs/buffer: Remove redundant assignment to err

On Mon, Mar 27, 2023 at 10:10:10AM +0200, Christian Brauner wrote:
> 
> On Thu, 23 Mar 2023 10:32:59 +0800, Jiapeng Chong wrote:
> > Variable 'err' set but not used.
> > 
> > fs/buffer.c:2613:2: warning: Value stored to 'err' is never read.
> > 
> > 
> 
> Applied to

I think you should exercise extreme care with patches from "Abaci Robot".
It's wrong more often than it's right, and the people interpreting the
output from it do not appear to be experienced programmers.